scroll-dev: ceno-recursion-verifier #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunxian-xia
reviewed
Jun 6, 2025
kunxian-xia
left a comment
kunxian-xia
left a comment
There was a problem hiding this comment.
LGTM except one minor comment issue.
kunxian-xia
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
against https://github.com/openvm-org/openvm/releases/tag/v1.0.0
sample_extopenvm-org@03827f1
We add a new IR instruction
DslIr::ExtFromBaseVecthat uses theAsmInstruction::CopyFinternally, to reduce the number of cycles introduced bysample_extthat used theSymbolicExtexpression approach before.